feat: HeadersWithUnderscoreActions on ClientTrafficPolicy #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3052 +/- ##
==========================================
+ Coverage 64.89% 64.90% +0.01%
==========================================
Files 121 121
Lines 21382 21393 +11
==========================================
+ Hits 13875 13886 +11
Misses 6639 6639
Partials 868 868 ☔ View full report in Codecov by Sentry. |
davidalger
force-pushed
the
algerdev/feat-headers-with-underscores-action
branch
2 times, most recently
from
0c6b66e to
9b95cab
Compare
Signed-off-by: David Alger <[email protected]>
davidalger
force-pushed
the
algerdev/feat-headers-with-underscores-action
branch
from
9b95cab to
bab490a
Compare
Signed-off-by: David Alger <[email protected]>
Xunzhuo
previously approved these changes
Mar 29, 2024
arkodg
reviewed
Mar 29, 2024
|
looks like a rebase is needed @davidalger |
# Conflicts: # site/content/en/latest/api/extension_types.md
Signed-off-by: David Alger <[email protected]>
arkodg
approved these changes
Mar 29, 2024
|
/retest |
ShyunnY
pushed a commit
to ShyunnY/gateway
that referenced
this pull request
Apr 1, 2024
…#3052) * feat: HeadersWithUnderscoreActions on ClientTrafficPolicy Signed-off-by: David Alger <[email protected]> * Add XDS translator test Signed-off-by: David Alger <[email protected]> * Rename using preferred func prefix Signed-off-by: David Alger <[email protected]> --------- Signed-off-by: David Alger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Adds configuration to
ClientTrafficPolicyto support overriding the default forHeadersWithUnderscoreActionsin common HTTP protocol options.What this PR does / why we need it:
Envoy defaults have
headers_with_underscores_actionset toALLOWwhile Envoy Gateway defaults toREJECT_REQUESTdespite the underscore character being allowed in header names by RFC-7230. This may be an ok default for EG to be more strict out of the box, but it breaks compatibility with preexisting API client configurations which send underscores in header names.