fixed obsolete links in the docs #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
reviewed
Mar 28, 2024
There was a problem hiding this comment.
there's plan to move contributions out of versions, xref: #2987
zirain
reviewed
Mar 28, 2024
| @@ -396,7 +396,7 @@ When considering internal threat actors, we chose to follow the [security model] | |||
|
|
|||
| **Threat**: Reduced API gateway availability due to an attacker\'s maliciously crafted request (e.g., QoD) potentially inducing a Denial of Service (DoS) attack. | |||
|
|
|||
| **Recommendation**: To ensure high availability and to mitigate potential security threats, adhere to the Envoy Gateway documentation for the configuration of a [rate-limiting](https://gateway.envoyproxy.io/v0.6.0/user/rate-limit/) filter and load balancing. | |||
| **Recommendation**: To ensure high availability and mitigate potential security threats, follow the guidelines in the Envoy Gateway documentation for configuring [local rate limit](https://gateway.envoyproxy.io/latest/user/traffic/local-rate-limit/) filters, [global rate limit](https://gateway.envoyproxy.io/latest/user/traffic/global-rate-limit/) filters, and load balancing. | |||
There was a problem hiding this comment.
Suggested change
| **Recommendation**: To ensure high availability and mitigate potential security threats, follow the guidelines in the Envoy Gateway documentation for configuring [local rate limit](https://gateway.envoyproxy.io/latest/user/traffic/local-rate-limit/) filters, [global rate limit](https://gateway.envoyproxy.io/latest/user/traffic/global-rate-limit/) filters, and load balancing. | |
| **Recommendation**: To ensure high availability and mitigate potential security threats, follow the guidelines in the Envoy Gateway documentation for configuring [local rate limit](../traffic/local-rate-limit/) filters, [global rate limit](../traffic/global-rate-limit/) filters, and load balancing. |
Signed-off-by: LiZhenCheng9527 <[email protected]>
LiZhenCheng9527
force-pushed
the
fix-doc
branch
from
0c07bfc to
997fbd4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3050 +/- ##
==========================================
- Coverage 64.56% 64.55% -0.01%
==========================================
Files 121 121
Lines 21369 21369
==========================================
- Hits 13796 13795 -1
- Misses 6707 6708 +1
Partials 866 866 ☔ View full report in Codecov by Sentry. |
zirain
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fixed obsolete links in the docs