Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set path prefix for http ext auth service #3018

Merged
merged 2 commits into from
Mar 26, 2024
Merged

fix: set path prefix for http ext auth service #3018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3402a02
fix: set path prefix for http ext auth service
zhaohuabing Mar 26, 2024
2fe5efb
Merge branch 'main' into ext-auth-http-path-prefix
zhaohuabing Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/xds/translator/extauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,13 @@ func httpService(http *ir.HTTPExtAuthService) *extauthv3.HttpService {
var (
uri string
headersToBackend []*matcherv3.StringMatcher
service = new(extauthv3.HttpService)
service *extauthv3.HttpService
)

service = &extauthv3.HttpService{
PathPrefix: http.Path,
}

u := url.URL{
// scheme should be decided by the TLS setting, but we don't have that info now.
// It's safe to set it to http because the ext auth filter doesn't use the
Expand Down
1 change: 1 addition & 0 deletions internal/xds/translator/testdata/out/xds-ir/ext-auth.listeners.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
patterns:
- exact: header1
- exact: header2
pathPrefix: /auth
serverUri:
cluster: securitypolicy/default/policy-for-gateway-1/envoy-gateway/http-backend
timeout: 10s
Expand Down
Loading