Refactor and fix early return: HTTP Listener XDS translator #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2981 +/- ##
==========================================
- Coverage 66.51% 58.94% -7.57%
==========================================
Files 161 162 +1
Lines 22673 27125 +4452
==========================================
+ Hits 15080 15990 +910
- Misses 6720 10182 +3462
- Partials 873 953 +80 ☔ View full report in Codecov by Sentry. |
zhaohuabing
changed the title
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-http-listener-missing-filters-refactor
branch
from
53acda0 to
0688a1a
Compare
Signed-off-by: huabing zhao <[email protected]>
…issing-filters-refactor
zhaohuabing
force-pushed
the
fix-http-listener-missing-filters-refactor
branch
from
ba79a3e to
7fa68a2
Compare
…issing-filters-refactor
|
any test for this? |
arkodg
reviewed
Apr 10, 2024
| @@ -194,7 +194,17 @@ func buildXdsQuicListener(name, address string, port uint32, accesslog *ir.Acces | |||
| return xdsListener | |||
| } | |||
|
|
|||
| func (t *Translator) addXdsHTTPFilterChain(xdsListener *listenerv3.Listener, irListener *ir.HTTPListener, | |||
| // addHCMToXDSListener adds a HCM filter to the listener's filter chain, and adds | |||
arkodg
approved these changes
Apr 10, 2024
zirain
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
processHTTPListenerXdsTranslationand extract anaddRouteToRouteConfigsub-method to make the HTTPListener construction a bit easier to understand and maintain.addXdsHTTPFilterChaintoaddHCMToXDSListenerto better reflect what this method does.