Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing http filters to the http filter chain #2970

Merged
merged 17 commits into from
Mar 27, 2024

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Mar 18, 2024

This PR patches HTTP filters on the existing HCM of an HTTP listener's DefaultFilterChain.

Fix #2742

@zhaohuabing zhaohuabing requested a review from a team as a code owner March 18, 2024 09:23
@zhaohuabing zhaohuabing marked this pull request as draft March 18, 2024 09:23
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 64.50%. Comparing base (a11aa70) to head (2e574ea).

Files Patch % Lines
internal/xds/translator/translator.go 55.55% 14 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2970      +/-   ##
==========================================
- Coverage   64.52%   64.50%   -0.02%     
==========================================
  Files         121      121              
  Lines       21344    21381      +37     
==========================================
+ Hits        13772    13792      +20     
- Misses       6706     6718      +12     
- Partials      866      871       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing force-pushed the fix-http-listener-missing-filters branch from 1b57329 to e988861 Compare March 18, 2024 09:29
@zhaohuabing zhaohuabing force-pushed the fix-http-listener-missing-filters branch from e988861 to 1e958d6 Compare March 19, 2024 04:36
@zhaohuabing zhaohuabing force-pushed the fix-http-listener-missing-filters branch from 1e958d6 to a3e863d Compare March 19, 2024 06:24
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing zhaohuabing marked this pull request as ready for review March 19, 2024 09:34
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing zhaohuabing requested review from arkodg and liorokman March 19, 2024 09:45
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing zhaohuabing force-pushed the fix-http-listener-missing-filters branch from cf12c73 to 53acda0 Compare March 19, 2024 09:57
@arkodg
Copy link
Contributor

arkodg commented Mar 19, 2024

hey @zhaohuabing thanks for working on the fix + the refactor
can we split up the refactor into another follow PR ? It allows us to back port this into v1.0.0

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing
Copy link
Member Author

/restest

@zhaohuabing zhaohuabing self-assigned this Mar 21, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team March 27, 2024 10:00
@zirain zirain merged commit f699edf into envoyproxy:main Mar 27, 2024
19 checks passed
yaelSchechter pushed a commit to yaelSchechter/envoy-gateway that referenced this pull request Mar 28, 2024
* fix: add missing http filters to the http filter chain

Signed-off-by: huabing zhao <[email protected]>

* refactor

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: huabing zhao <[email protected]>

* add comments

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* fix gen

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
arkodg added a commit that referenced this pull request Mar 28, 2024
* build(deps): bump github.com/prometheus/common from 0.50.0 to 0.51.1 (#3010)

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.50.0 to 0.51.1.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.50.0...v0.51.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* docs: fix squash link (#3013)

Signed-off-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* api: support IdleTimeout in clientTrafficPolicy

Signed-off-by: Yael Shechter <[email protected]>

* build(deps): bump fortio.org/fortio from 1.63.4 to 1.63.5 (#3011)

Bumps [fortio.org/fortio](https://github.com/fortio/fortio) from 1.63.4 to 1.63.5.
- [Release notes](https://github.com/fortio/fortio/releases)
- [Commits](fortio/fortio@v1.63.4...v1.63.5)

---
updated-dependencies:
- dependency-name: fortio.org/fortio
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* ci: trigger docs action (#3017)

Signed-off-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* ci: fix cherrypick permission (#2985)

Signed-off-by: zirain <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* fix: set path prefix for http ext auth service (#3018)

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* feat: add Chinese language support for doc site (#2532)

* Add Chinese support for doc site

Signed-off-by: Wilson Wu <[email protected]>

* Add zh i18n for menus

Signed-off-by: Wilson Wu <[email protected]>

* Add zh content placeholders

Signed-off-by: Wilson Wu <[email protected]>

* Fix about zh page

Signed-off-by: Wilson Wu <[email protected]>

* Apply suggestions from code review

Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Wilson Wu <[email protected]>

* docs: `%s/Application/API/g` (#2929)

Signed-off-by: Wilson Wu <[email protected]>

* remove old version for zh content

Signed-off-by: Wilson Wu <[email protected]>

* Update the latest version link

Signed-off-by: Wilson Wu <[email protected]>

* Fix default content dir

Signed-off-by: Wilson Wu <[email protected]>

* Translate landing page and fix broken link

Signed-off-by: Wilson Wu <[email protected]>

* Fix broken link

Signed-off-by: Wilson Wu <[email protected]>

* Add a contribution page

Signed-off-by: Wilson Wu <[email protected]>

---------

Signed-off-by: Wilson Wu <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* feat(translator): implement connection limit (#2952)

* implement connection limit

Signed-off-by: Guy Daich <[email protected]>

* fix lint

Signed-off-by: Guy Daich <[email protected]>

* fix lint 2

Signed-off-by: Guy Daich <[email protected]>

* fix ir, coverage

Signed-off-by: Guy Daich <[email protected]>

* fix lint 3

Signed-off-by: Guy Daich <[email protected]>

* open more connection in e2e

Signed-off-by: Guy Daich <[email protected]>

* fix error type

Signed-off-by: Guy Daich <[email protected]>

* add additional connections

Signed-off-by: Guy Daich <[email protected]>

* make limit value required

Signed-off-by: Guy Daich <[email protected]>

* add error-flow unit test

Signed-off-by: Guy Daich <[email protected]>

* fix lint 4

Signed-off-by: Guy Daich <[email protected]>

* assert policy accepted in test

Signed-off-by: Guy Daich <[email protected]>

* rename limit => connectionLimit

Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* docs: remove 0.1.0  from linkinator ignore list (#3015)

Signed-off-by: yuluo <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* disable connection limit test (#3025)

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* fix: use correct connection limit attribute name in e2e, docs (#3028)

fix attribute name

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* docs: document patches in envoy proxy (#3027)

* docs: document patches in envoy proxy

Signed-off-by: Yael Shechter <[email protected]>

* fix linting issue

Signed-off-by: Yael Shechter <[email protected]>

* fix pr comment

Signed-off-by: Yael Shechter <[email protected]>

---------

Signed-off-by: Yael Shechter <[email protected]>

* feat(policy): Adding BTP support for UDP/TCPRoute (#3004)

* Adding BTP support for UDP/TCP Routes

Signed-off-by: Alexander Volchok <[email protected]>

* fixining lint

Signed-off-by: Alexander Volchok <[email protected]>

* fix IdleTime check

Signed-off-by: Alexander Volchok <[email protected]>

* adding missing generates

Signed-off-by: Alexander Volchok <[email protected]>

* fixing code review comments

Signed-off-by: Alexander Volchok <[email protected]>

* incresing code coverage

Signed-off-by: Alexander Volchok <[email protected]>

---------

Signed-off-by: Alexander Volchok <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* fix: add missing http filters to the http filter chain (#2970)

* fix: add missing http filters to the http filter chain

Signed-off-by: huabing zhao <[email protected]>

* refactor

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: huabing zhao <[email protected]>

* add comments

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* fix gen

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* fix pr comment

Signed-off-by: Yael Shechter <[email protected]>

* ci: grant pull-requests permission to cherrypick action (#3039)

Signed-off-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* Update ADOPTERS.md for Airspace Link (#3045)

Signed-off-by: Fabrice Aneche <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* feat: added option to specify resources on the OIDC security policy (#3030)

added option to specify resources on the OIDC filter

Signed-off-by: jaynis <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* run make commands

Signed-off-by: Yael Shechter <[email protected]>

* fix: allow websockets in url rewrite (#3022)

allow websockets in url rewrite

Signed-off-by: Jesse Haka <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Wilson Wu <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: yuluo <[email protected]>
Signed-off-by: Alexander Volchok <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Fabrice Aneche <[email protected]>
Signed-off-by: jaynis <[email protected]>
Signed-off-by: Jesse Haka <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Wilson Wu <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: Guy Daich <[email protected]>
Co-authored-by: YuLuo <[email protected]>
Co-authored-by: Alex Volchok <[email protected]>
Co-authored-by: Fabrice Aneche <[email protected]>
Co-authored-by: jaynis <[email protected]>
Co-authored-by: Jesse Haka <[email protected]>
ShyunnY pushed a commit to ShyunnY/gateway that referenced this pull request Apr 1, 2024
* fix: add missing http filters to the http filter chain

Signed-off-by: huabing zhao <[email protected]>

* refactor

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: huabing zhao <[email protected]>

* add comments

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* fix gen

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
ShyunnY pushed a commit to ShyunnY/gateway that referenced this pull request Apr 1, 2024
* build(deps): bump github.com/prometheus/common from 0.50.0 to 0.51.1 (envoyproxy#3010)

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.50.0 to 0.51.1.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.50.0...v0.51.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* docs: fix squash link (envoyproxy#3013)

Signed-off-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* api: support IdleTimeout in clientTrafficPolicy

Signed-off-by: Yael Shechter <[email protected]>

* build(deps): bump fortio.org/fortio from 1.63.4 to 1.63.5 (envoyproxy#3011)

Bumps [fortio.org/fortio](https://github.com/fortio/fortio) from 1.63.4 to 1.63.5.
- [Release notes](https://github.com/fortio/fortio/releases)
- [Commits](fortio/fortio@v1.63.4...v1.63.5)

---
updated-dependencies:
- dependency-name: fortio.org/fortio
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* ci: trigger docs action (envoyproxy#3017)

Signed-off-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* ci: fix cherrypick permission (envoyproxy#2985)

Signed-off-by: zirain <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* fix: set path prefix for http ext auth service (envoyproxy#3018)

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* feat: add Chinese language support for doc site (envoyproxy#2532)

* Add Chinese support for doc site

Signed-off-by: Wilson Wu <[email protected]>

* Add zh i18n for menus

Signed-off-by: Wilson Wu <[email protected]>

* Add zh content placeholders

Signed-off-by: Wilson Wu <[email protected]>

* Fix about zh page

Signed-off-by: Wilson Wu <[email protected]>

* Apply suggestions from code review

Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Wilson Wu <[email protected]>

* docs: `%s/Application/API/g` (envoyproxy#2929)

Signed-off-by: Wilson Wu <[email protected]>

* remove old version for zh content

Signed-off-by: Wilson Wu <[email protected]>

* Update the latest version link

Signed-off-by: Wilson Wu <[email protected]>

* Fix default content dir

Signed-off-by: Wilson Wu <[email protected]>

* Translate landing page and fix broken link

Signed-off-by: Wilson Wu <[email protected]>

* Fix broken link

Signed-off-by: Wilson Wu <[email protected]>

* Add a contribution page

Signed-off-by: Wilson Wu <[email protected]>

---------

Signed-off-by: Wilson Wu <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* feat(translator): implement connection limit (envoyproxy#2952)

* implement connection limit

Signed-off-by: Guy Daich <[email protected]>

* fix lint

Signed-off-by: Guy Daich <[email protected]>

* fix lint 2

Signed-off-by: Guy Daich <[email protected]>

* fix ir, coverage

Signed-off-by: Guy Daich <[email protected]>

* fix lint 3

Signed-off-by: Guy Daich <[email protected]>

* open more connection in e2e

Signed-off-by: Guy Daich <[email protected]>

* fix error type

Signed-off-by: Guy Daich <[email protected]>

* add additional connections

Signed-off-by: Guy Daich <[email protected]>

* make limit value required

Signed-off-by: Guy Daich <[email protected]>

* add error-flow unit test

Signed-off-by: Guy Daich <[email protected]>

* fix lint 4

Signed-off-by: Guy Daich <[email protected]>

* assert policy accepted in test

Signed-off-by: Guy Daich <[email protected]>

* rename limit => connectionLimit

Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* docs: remove 0.1.0  from linkinator ignore list (envoyproxy#3015)

Signed-off-by: yuluo <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* disable connection limit test (envoyproxy#3025)

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* fix: use correct connection limit attribute name in e2e, docs (envoyproxy#3028)

fix attribute name

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* docs: document patches in envoy proxy (envoyproxy#3027)

* docs: document patches in envoy proxy

Signed-off-by: Yael Shechter <[email protected]>

* fix linting issue

Signed-off-by: Yael Shechter <[email protected]>

* fix pr comment

Signed-off-by: Yael Shechter <[email protected]>

---------

Signed-off-by: Yael Shechter <[email protected]>

* feat(policy): Adding BTP support for UDP/TCPRoute (envoyproxy#3004)

* Adding BTP support for UDP/TCP Routes

Signed-off-by: Alexander Volchok <[email protected]>

* fixining lint

Signed-off-by: Alexander Volchok <[email protected]>

* fix IdleTime check

Signed-off-by: Alexander Volchok <[email protected]>

* adding missing generates

Signed-off-by: Alexander Volchok <[email protected]>

* fixing code review comments

Signed-off-by: Alexander Volchok <[email protected]>

* incresing code coverage

Signed-off-by: Alexander Volchok <[email protected]>

---------

Signed-off-by: Alexander Volchok <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* fix: add missing http filters to the http filter chain (envoyproxy#2970)

* fix: add missing http filters to the http filter chain

Signed-off-by: huabing zhao <[email protected]>

* refactor

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: huabing zhao <[email protected]>

* add comments

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* fix gen

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* fix pr comment

Signed-off-by: Yael Shechter <[email protected]>

* ci: grant pull-requests permission to cherrypick action (envoyproxy#3039)

Signed-off-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* Update ADOPTERS.md for Airspace Link (envoyproxy#3045)

Signed-off-by: Fabrice Aneche <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* feat: added option to specify resources on the OIDC security policy (envoyproxy#3030)

added option to specify resources on the OIDC filter

Signed-off-by: jaynis <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* run make commands

Signed-off-by: Yael Shechter <[email protected]>

* fix: allow websockets in url rewrite (envoyproxy#3022)

allow websockets in url rewrite

Signed-off-by: Jesse Haka <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Wilson Wu <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: yuluo <[email protected]>
Signed-off-by: Alexander Volchok <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Fabrice Aneche <[email protected]>
Signed-off-by: jaynis <[email protected]>
Signed-off-by: Jesse Haka <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Wilson Wu <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: Guy Daich <[email protected]>
Co-authored-by: YuLuo <[email protected]>
Co-authored-by: Alex Volchok <[email protected]>
Co-authored-by: Fabrice Aneche <[email protected]>
Co-authored-by: jaynis <[email protected]>
Co-authored-by: Jesse Haka <[email protected]>
arkodg pushed a commit to arkodg/gateway that referenced this pull request Apr 8, 2024
* fix: add missing http filters to the http filter chain

Signed-off-by: huabing zhao <[email protected]>

* refactor

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: huabing zhao <[email protected]>

* add comments

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* fix gen

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
(cherry picked from commit f699edf)
Signed-off-by: Arko Dasgupta <[email protected]>
Xunzhuo added a commit that referenced this pull request Apr 8, 2024
* Run certgen when upgrading (#2934)

run certgen when upgrading

Signed-off-by: huabing zhao <[email protected]>
(cherry picked from commit 62ecf15)
Signed-off-by: Arko Dasgupta <[email protected]>

* Fix: nil secret in resourceversiontable (#2982)

* fix nil secret in resourceversiontable

Signed-off-by: huabing zhao <[email protected]>

* check secrets in the xds result

Signed-off-by: huabing zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
(cherry picked from commit e880439)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: add missing http filters to the http filter chain (#2970)

* fix: add missing http filters to the http filter chain

Signed-off-by: huabing zhao <[email protected]>

* refactor

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: huabing zhao <[email protected]>

* add comments

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* fix gen

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
(cherry picked from commit f699edf)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: allow websockets in url rewrite (#3022)

allow websockets in url rewrite

Signed-off-by: Jesse Haka <[email protected]>
Co-authored-by: zirain <[email protected]>
(cherry picked from commit 3d51933)
Signed-off-by: Arko Dasgupta <[email protected]>

* Set host for http health checker explicitly to avoid using the cluster name as host header for http health checking request. (#3057)

* Set host for http health checker explictly to avoid using the cluster name as host header for http health checking request

Signed-off-by: lemonlinger <[email protected]>

* fix broken tests

Signed-off-by: lemonlinger <[email protected]>

* fix health-check test case in xds translation

Signed-off-by: lemonlinger <[email protected]>

* Simplify code and concise comments

Signed-off-by: lemonlinger <[email protected]>

---------

Signed-off-by: lemonlinger <[email protected]>
(cherry picked from commit 8f450a9)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: do not create infra resources when missing translated listeners (#3043)

* fix: do not create infra resources when missing translated listeners

Signed-off-by: Karol Szwaj <[email protected]>

* remove empty line

Signed-off-by: Karol Szwaj <[email protected]>

* skip infra creation on empty listeners and log it

Signed-off-by: Karol Szwaj <[email protected]>

---------

Signed-off-by: Karol Szwaj <[email protected]>
(cherry picked from commit 36d7141)
Signed-off-by: Arko Dasgupta <[email protected]>

* Fix: double slashes in redirect URL (#2998)

* fix: double trailing splashs in redirect URL

Signed-off-by: huabing zhao <[email protected]>

* add e2e tests

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: huabing zhao <[email protected]>

* fix test

Signed-off-by: huabing zhao <[email protected]>

* fix test

Signed-off-by: huabing zhao <[email protected]>

* fix test

Signed-off-by: huabing zhao <[email protected]>

* fix test

Signed-off-by: huabing zhao <[email protected]>

* add e2e tests

Signed-off-by: huabing zhao <[email protected]>

* fix test

Signed-off-by: huabing zhao <[email protected]>

* revert

Signed-off-by: huabing zhao <[email protected]>

* use regex rewrite to generate the redirect url

Signed-off-by: huabing zhao <[email protected]>

* use regex rewrite to generate the redirect url

Signed-off-by: huabing zhao <[email protected]>

* use regex rewrite to generate the redirect url

Signed-off-by: huabing zhao <[email protected]>

* remove comments

Signed-off-by: huabing zhao <[email protected]>

* extract method

Signed-off-by: huabing zhao <[email protected]>

* address comments

Signed-off-by: huabing zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
(cherry picked from commit ceb697f)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: Allow Policy to attach to multiple http listeners  (#2967)

* Fixing the clienttrafficpolicy validation.

Signed-off-by: Lior Okman <[email protected]>

* Make SecurityPolicy validate correctly.

Signed-off-by: Lior Okman <[email protected]>

* Reverted the SecurityPolicy validation - handled differently via
another feature.

Signed-off-by: Lior Okman <[email protected]>

* Updated the tests to reflect that this validation isn't required for SecurityPolicy

Signed-off-by: Lior Okman <[email protected]>

* Added some comments to explain the validation being performed.

Signed-off-by: Lior Okman <[email protected]>

* Updated the error message as requested in the review.

Signed-off-by: Lior Okman <[email protected]>

---------

Signed-off-by: Lior Okman <[email protected]>
(cherry picked from commit f9409e4)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: set path prefix for http ext auth service (#3018)

Signed-off-by: huabing zhao <[email protected]>
(cherry picked from commit 2882b7c)
Signed-off-by: Arko Dasgupta <[email protected]>

* Change route sorting order to Exact > RegularExpression > PathPrefix (#2579)

* Change route sorting order to Exact > RegularExpression > PathPrefix

kubernetes-sigs/gateway-api#1770
kubernetes-sigs/gateway-api#1855

Signed-off-by: Stéphane Cottin <[email protected]>
(cherry picked from commit 11f56fd)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: infraIR duplicate port translation for merged gateways (#3061)

* fix: duplicate port translation for merged gateways

Signed-off-by: Karol Szwaj <[email protected]>

* refactor to map

Signed-off-by: Karol Szwaj <[email protected]>

* rename map

Signed-off-by: Karol Szwaj <[email protected]>

* add seperate testcase

Signed-off-by: Karol Szwaj <[email protected]>

---------

Signed-off-by: Karol Szwaj <[email protected]>
(cherry picked from commit 29946b0)
Signed-off-by: Arko Dasgupta <[email protected]>

* translator: set SpawnUpstreamSpan to true (#3102)

* translator: set SpawnUpstreamSpan to true

Signed-off-by: zirain <[email protected]>

* update

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 635ebfc)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: rate limit doesn't work with two(and more) listeners (#3085)

* fix: rate limit doesn't work with two listeners

Signed-off-by: huabing zhao <[email protected]>

* add e2e test for rate limit on multiple listeners

Signed-off-by: huabing zhao <[email protected]>

* address comments

Signed-off-by: huabing zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Co-authored-by: Xunzhuo <[email protected]>
(cherry picked from commit a5bedbc)
Signed-off-by: Arko Dasgupta <[email protected]>

* rerun make testdata

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Jesse Haka <[email protected]>
Signed-off-by: lemonlinger <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Lior Okman <[email protected]>
Signed-off-by: Stéphane Cottin <[email protected]>
Signed-off-by: zirain <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Co-authored-by: Jesse Haka <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Meng <[email protected]>
Co-authored-by: Karol Szwaj <[email protected]>
Co-authored-by: Lior Okman <[email protected]>
Co-authored-by: vixns <[email protected]>
Co-authored-by: Xunzhuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants