Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use v1.0.0 as default for upgrade test #2938

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Mar 15, 2024

What this PR does / why we need it:
Now that v1.0.0 is released, we should use it a baseline for upgrade tests in CI.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc requested a review from a team as a code owner March 15, 2024 12:26
@guydc guydc changed the title use v1.0.0 as default for upgrade test chore: use v1.0.0 as default for upgrade test Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.57%. Comparing base (62ecf15) to head (7b735c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2938   +/-   ##
=======================================
  Coverage   64.57%   64.57%           
=======================================
  Files         122      122           
  Lines       21115    21115           
=======================================
  Hits        13636    13636           
  Misses       6632     6632           
  Partials      847      847           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guydc
Copy link
Contributor Author

guydc commented Mar 15, 2024

/retest

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we cover one more old version(v 0.0.6)?

@arkodg
Copy link
Contributor

arkodg commented Mar 15, 2024

@zhaohuabing the release/v1.0 branch already has the v0.6 to v1.0 test

@guydc guydc merged commit 6c6f92f into envoyproxy:main Mar 15, 2024
19 checks passed
@zhaohuabing
Copy link
Member

Do we support upgrade from v0.6 to latest?

@arkodg
Copy link
Contributor

arkodg commented Mar 16, 2024

@zhaohuabing id suggest we start with only claiming support for migrating from one minor version to the next minor version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants