-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extension service example project #2931
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
==========================================
+ Coverage 64.57% 64.59% +0.01%
==========================================
Files 122 122
Lines 21115 21115
==========================================
+ Hits 13636 13639 +3
+ Misses 6632 6630 -2
+ Partials 847 846 -1 ☔ View full report in Codecov by Sentry. |
c915afa
to
db31e8d
Compare
thanks for adding this @AliceProxy ! the community seems very interested into a strongly typed and programmatic way |
Right now this doesn't add any new docs to CI with the license check is failing and I'm not sure if we want to add the copyright comment to the go files within this example project or not since it's meant as a reference that community members can use as-is and modify, but I can add those in if we like. The gen-check seems to be complaining about the go mod and go generation stuff used in here I haven't looked into that one much yet but it might make sense to try and have it ignore this directory. |
Signed-off-by: Alice Wasko <[email protected]>
Signed-off-by: Alice Wasko <[email protected]>
db31e8d
to
5d38821
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FTR I'd vote for adding copyright -- Envoy Gateway is already Apache-2 licensed, which is pretty permissive. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
superseded by #3788 |
This adds a demo project for an extension under the examples section. It's setup as a fully fledged project that can be used as a base or an example for creating an Envoy Gateway extension. The
README.md
file contains a walkthrough to deploy a pre-built image of the demo, and instructions for how you can build and modify it to suit your needs.The example adds a custom resource
GlobalLuaScript
. The extension has a controller to watch these resources, and when it gets xDS modification hook requests from Envoy Gateway, it will inject HTTP filters for the lua script resources so that they run against all requests.Example logs:
The
README.md
file shows how to setup the extension, configure Envoy Gateway to use it, and create an instance of aGlobalLuaScript
that addslua-script-enabled: Processed
as a response header to all requests.