Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset translate in retry #2756

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Mar 3, 2024

Which issue(s) this PR fixes:
Fixes #2755

@guydc guydc requested a review from a team as a code owner March 3, 2024 16:06
@guydc guydc changed the title fix: reset transalte in retry fix: reset translate in retry Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.63%. Comparing base (93d6d21) to head (a8216a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2756   +/-   ##
=======================================
  Coverage   63.63%   63.63%           
=======================================
  Files         123      123           
  Lines       20189    20189           
=======================================
  Hits        12847    12847           
  Misses       6519     6519           
  Partials      823      823           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

guydc added 2 commits March 3, 2024 17:51

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc force-pushed the fix-retry-reset-translate branch from 7325051 to a8216a2 Compare March 3, 2024 23:57
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team March 4, 2024 00:24
@zirain zirain merged commit 75fcedc into envoyproxy:main Mar 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: translation mistake in retry triggers
3 participants