fix: remove no needed new pointer creation

[Xunzhuo]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

remove no needed new pointer creation

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.45%. Comparing base (c2ad8c1) to head (5bb431b).
Report is 169 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2739      +/-   ##
==========================================
- Coverage   63.48%   63.45%   -0.04%     
==========================================
  Files         125      125              
  Lines       20547    20538       -9     
==========================================
- Hits        13045    13033      -12     
- Misses       6666     6667       +1     
- Partials      836      838       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zirain]

I recall there's an improment in upstream go, but I cannot recall which version and commit, can you link it?

[cnvergence]

lgtm

[Xunzhuo]

@zirain I did not get, and it should be none-related to this PR.

Can we get this in ?

[zhaohuabing]

I guess it's related to the variable scope in loop: https://go.dev/blog/loopvar-preview

For Go 1.22, we plan to change for loops to make these variables have per-iteration scope instead of per-loop scope.

It's fixed in Go 1.22, but why lint removes this check in 1.21 ?

[zirain]

I guess it's related to the variable scope in loop: https://go.dev/blog/loopvar-preview

For Go 1.22, we plan to change for loops to make these variables have per-iteration scope instead of per-loop scope.

It's fixed in Go 1.22, but why lint removes this check in 1.21 ?

yeah, that's what I mean.

should we hold this until we move to go1.22?

[Xunzhuo]

Sure, let us hold for bumping go version.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

[shawnh2]

This loopvar feature of go 1.22 requires enable env GOEXPERIMENT=loopvar (default closed) explicitly. Maybe we could consider enable this feature for other places as well.