Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: filename be more gopher #2735

Merged
merged 2 commits into from
Mar 1, 2024
Merged

chore: filename be more gopher #2735

merged 2 commits into from
Mar 1, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Mar 1, 2024

No description provided.

@zirain zirain requested a review from a team as a code owner March 1, 2024 05:21
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.45%. Comparing base (bfca32e) to head (c4dea31).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2735   +/-   ##
=======================================
  Coverage   63.45%   63.45%           
=======================================
  Files         123      123           
  Lines       20065    20065           
=======================================
  Hits        12732    12732           
  Misses       6519     6519           
  Partials      814      814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to know how file names should look like as a true gopher :-)

@Xunzhuo Xunzhuo merged commit 8751461 into envoyproxy:main Mar 1, 2024
5 of 6 checks passed
@zirain zirain deleted the filename branch March 1, 2024 07:22
Xunzhuo added a commit to Xunzhuo/gateway that referenced this pull request Mar 1, 2024
@Xunzhuo Xunzhuo mentioned this pull request Mar 1, 2024
Xunzhuo added a commit that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants