Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix helm chart install docs #2722

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

phantooom
Copy link
Contributor

@phantooom phantooom commented Feb 28, 2024

What type of PR is this?

  • "docs: fix helm chart install script"

@phantooom phantooom requested a review from a team as a code owner February 28, 2024 06:44
@phantooom phantooom force-pushed the rui.zou/fix-helm-docs branch from f2d12e0 to 8ed43a7 Compare February 28, 2024 06:45
zirain
zirain previously approved these changes Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.34%. Comparing base (6d8337e) to head (2b5db3b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2722   +/-   ##
=======================================
  Coverage   63.34%   63.34%           
=======================================
  Files         123      123           
  Lines       19979    19979           
=======================================
  Hits        12655    12655           
  Misses       6513     6513           
  Partials      811      811           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phantooom phantooom force-pushed the rui.zou/fix-helm-docs branch from 8ed43a7 to 2b5db3b Compare February 28, 2024 08:17
@shawnh2
Copy link
Contributor

shawnh2 commented Feb 28, 2024

/retest

@arkodg arkodg merged commit 26d9d97 into envoyproxy:main Feb 28, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants