chore: update TestDeployment #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
==========================================
+ Coverage 63.29% 63.34% +0.05%
==========================================
Files 123 123
Lines 19991 19991
==========================================
+ Hits 12654 12664 +10
+ Misses 6522 6514 -8
+ Partials 815 813 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zirain <[email protected]>
arkodg
reviewed
Feb 28, 2024
| @@ -550,6 +544,15 @@ func TestDeployment(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| if os.Getenv("UPDATE_TESTDATA") != "" { | |||
There was a problem hiding this comment.
can we use this approach
Line 49 in 26d9d97
Signed-off-by: zirain <[email protected]>
Xunzhuo
reviewed
Feb 29, 2024
yes |
|
Thanks for confirming, I met this issue when I firstly add |
arkodg
approved these changes
Feb 29, 2024
zhaohuabing
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update TestDeployment, so the
defaulttest output became same as the real world