Revert "build(deps): bump github.com/norwoodj/helm-docs from 1.12.0 to 1.13.0 in /tools/src/helm-docs" #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2718 +/- ##
==========================================
+ Coverage 63.34% 63.36% +0.02%
==========================================
Files 123 123
Lines 19979 19979
==========================================
+ Hits 12655 12659 +4
+ Misses 6513 6510 -3
+ Partials 811 810 -1 ☔ View full report in Codecov by Sentry. |
arkodg
approved these changes
Feb 27, 2024
shawnh2
approved these changes
Feb 27, 2024
…o 1.13.0…" This reverts commit f316c69. Signed-off-by: Guy Daich <[email protected]>
guydc
force-pushed
the
revert-2697-dependabot/go_modules/tools/src/helm-docs/github.com/norwoodj/helm-docs-1.13.0
branch
from
f8c2b19 to
1c81bd7
Compare
|
sorry, force pushed to fix sign-off on auto-generated PR |
|
/retest |
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Feb 28, 2024
…o 1.13.0 in /tools/src/helm-docs" (envoyproxy#2718) Revert "build(deps): bump github.com/norwoodj/helm-docs from 1.12.0 to 1.13.0…" This reverts commit f316c69. Signed-off-by: Guy Daich <[email protected]> Signed-off-by: zirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2697
The
toolchaininstruction added in go.mod in this change seems to break docs generation, e.g. here: https://github.com/envoyproxy/gateway/actions/runs/8072567519/job/22054604017?pr=2715