e2e: add test for jwt claim base routing #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2712 +/- ##
==========================================
+ Coverage 63.34% 63.42% +0.08%
==========================================
Files 123 123
Lines 19979 19979
==========================================
+ Hits 12655 12671 +16
+ Misses 6513 6500 -13
+ Partials 811 808 -3 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Feb 28, 2024
arkodg
reviewed
Feb 28, 2024
test/e2e/testdata/jwt.yaml
Outdated
| # catch all | ||
| - backendRefs: | ||
| - kind: Service | ||
| name: infra-backend-v3 |
There was a problem hiding this comment.
lets make this non existent (infra-backend-invalid) since that is what users will most likely do
There was a problem hiding this comment.
TIL, I used to think it will be ignored if name is not found.
There was a problem hiding this comment.
status will be set to ResolvedRef=False and requests will get 500
we ideally need something like #2714 but it doesnt exist today :(
There was a problem hiding this comment.
it's added to istio recently.
arkodg
reviewed
Feb 28, 2024
zirain
force-pushed
the
jwt-e2e
branch
2 times, most recently
from
02108f2 to
0304449
Compare
Signed-off-by: zirain <[email protected]>
|
/retest |
zhaohuabing
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2690