Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add egctl ratelimit config support #2674

Merged
merged 3 commits into from
Feb 26, 2024

fix: pkg sort and refactor check status by rate limit pod

756c017
Select commit
Loading
Failed to load commit list.
Merged

feat: add egctl ratelimit config support #2674

fix: pkg sort and refactor check status by rate limit pod
756c017
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 26, 2024 in 0s

62.98% (target 60.00%)

View this Pull Request on Codecov

62.98% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 45.00000% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 62.98%. Comparing base (4c79ef9) to head (756c017).
Report is 18 commits behind head on main.

Files Patch % Lines
internal/cmd/egctl/config_ratelimit.go 43.05% 72 Missing and 10 partials ⚠️
internal/cmd/egctl/config_cmd.go 0.00% 3 Missing ⚠️
internal/cmd/egctl/envoy_stats.go 0.00% 2 Missing ⚠️
internal/cmd/egctl/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2674      +/-   ##
==========================================
- Coverage   63.38%   62.98%   -0.41%     
==========================================
  Files         119      122       +3     
  Lines       19098    19756     +658     
==========================================
+ Hits        12106    12443     +337     
- Misses       6193     6506     +313     
- Partials      799      807       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov