-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add egctl experimental dashboard envoy-proxy
to render the admin dashboard for the proxy
#2669
Conversation
Sample cmd out:
|
Signed-off-by: xiaopeng <[email protected]>
Signed-off-by: xiaopeng <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2669 +/- ##
==========================================
- Coverage 63.38% 63.00% -0.39%
==========================================
Files 119 121 +2
Lines 19098 19574 +476
==========================================
+ Hits 12106 12332 +226
- Misses 6193 6441 +248
- Partials 799 801 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: xiaopeng <[email protected]>
@shawnh2 Thank you for the review! I think I have addressed all the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
What type of PR is this?
/feature
What this PR does / why we need it:
Render the admin dashboard for the proxy, to see things like configdumps without extra steps.