Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match mergedGateways irKey for ClientTrafficPolicy #2662

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

cnvergence
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

@cnvergence cnvergence requested a review from a team as a code owner February 20, 2024 12:11
@cnvergence
Copy link
Member Author

/retest

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (579b3b4) 63.36% compared to head (363bd4c) 63.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2662   +/-   ##
=======================================
  Coverage   63.36%   63.36%           
=======================================
  Files         119      119           
  Lines       19234    19234           
=======================================
  Hits        12187    12187           
  Misses       6233     6233           
  Partials      814      814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this !

@arkodg arkodg merged commit 5e78542 into envoyproxy:main Feb 20, 2024
19 checks passed
@cnvergence cnvergence deleted the add-merge-gateways-ctp branch February 21, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants