fix: Envoy rejects XDS at runtime losing all routes on restart #2576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: Envoy rejects XDS at runtime losing all routes on restart
What this PR does / why we need it:
By default Envoy rejects regex routes with a max program size > 100, which is very easy to trigger with simple regex matches:
When envoy restarts, it loses all it's config resulting in 404 responses to all requests. This change lifts the deprecated validation done by
max_program_size
leaving in place a warning threshold which can be used to monitor for high complexity regex routes without putting stability of the system at risk. See thread on the related issue for full details.Which issue(s) this PR fixes:
Relates #2543