Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Passive Health Checks (Outlier Detection) #2556

Merged
merged 7 commits into from
Feb 12, 2024
Merged

feat: add support for Passive Health Checks (Outlier Detection) #2556

merged 7 commits into from
Feb 12, 2024

Conversation

deszhou
Copy link
Contributor

@deszhou deszhou commented Feb 3, 2024

What this PR does / why we need it:
add support for Passive Health Checks
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/outlier
Which issue(s) this PR fixes:

Fixes #2552

@deszhou deszhou requested a review from a team as a code owner February 3, 2024 16:37
@deszhou
fix lint
9b3f1f9 
Signed-off-by: yeedove <[email protected]>
@deszhou
fix gen
40cc4cf 
Signed-off-by: yeedove <[email protected]>
@deszhou
fix gen
7168075 
Signed-off-by: yeedove <[email protected]>
@deszhou
fix test
4377fde 
Signed-off-by: yeedove <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2024 •
edited
Loading

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (5acc233) 64.09% compared to head (78c19e8) 63.88%.

Files Patch % Lines
internal/ir/zz_generated.deepcopy.go 0.00% 89 Missing ⚠️
internal/xds/translator/cluster.go 79.03% 8 Missing and 5 partials ⚠️
internal/gatewayapi/backendtrafficpolicy.go 78.57% 4 Missing and 2 partials ⚠️
internal/ir/xds.go 91.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2556      +/-   ##
==========================================
- Coverage   64.09%   63.88%   -0.21%     
==========================================
  Files         119      119              
  Lines       18628    18753     +125     
==========================================
+ Hits        11939    11980      +41     
- Misses       5906     5984      +78     
- Partials      783      789       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shawnh2
shawnh2 reviewed Feb 4, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some comments, generally LGTM

api/v1alpha1/healthcheck_types.go Outdated Show resolved Hide resolved
internal/ir/xds.go Outdated Show resolved Hide resolved
@zirain
Copy link
Member

zirain commented Feb 4, 2024

let's fcous on API first, otherwise there may be a lot of waste your time.

@deszhou
Copy link
Contributor Author

deszhou commented Feb 4, 2024

@zirain @shawnh2 done, thanks!

@deszhou
Copy link
Contributor Author

deszhou commented Feb 6, 2024

/retest

@deszhou deszhou requested a review from shawnh2 February 6, 2024 07:25
@arkodg
Copy link
Contributor

arkodg commented Feb 6, 2024

thanks for adding this API @yeedove
looks like the fields introduced are a 1:1 subset of https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/outlier_detection.proto#
@envoyproxy/gateway-maintainers should we introduce all these fields as part of the first iteration ?

arkodg
arkodg previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for introducing this !

@arkodg arkodg requested review from a team February 8, 2024 07:05
shawnh2
shawnh2 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zirain
zirain previously approved these changes Feb 10, 2024
View reviewed changes
@deszhou deszhou dismissed stale reviews from zirain and arkodg via 78c19e8 February 10, 2024 11:11
@deszhou
Copy link
Contributor Author

deszhou commented Feb 10, 2024

Resolved the conflict.

@arkodg arkodg merged commit da092e0 into envoyproxy:main Feb 12, 2024
19 of 20 checks passed
vixns pushed a commit to vixns/gateway that referenced this pull request Feb 18, 2024
@deszhou @vixns
feat: add support for Passive Health Checks (Outlier Detection) (envo…
14f5d8d 
…yproxy#2556)

* feat: add support for Passive Health Checks (Outlier Detection)

Signed-off-by: yeedove <[email protected]>

* fix lint

Signed-off-by: yeedove <[email protected]>

* fix gen

* use ptr type for the optional

Signed-off-by: yeedove <[email protected]>

---------

Signed-off-by: yeedove <[email protected]>
Signed-off-by: Stéphane Cottin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnh2 shawnh2 shawnh2 approved these changes

@arkodg arkodg arkodg approved these changes

@zirain zirain zirain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Passive Health Checks (Outlier Detection)
4 participants
@deszhou @zirain @arkodg @shawnh2