feat: add support for egctl x status
#2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <[email protected]>
shawnh2
force-pushed
the
egctl-x-status
branch
from
1680f71 to
93a6ed3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2550 +/- ##
==========================================
- Coverage 64.50% 63.93% -0.58%
==========================================
Files 116 117 +1
Lines 17757 18057 +300
==========================================
+ Hits 11455 11545 +90
- Misses 5560 5760 +200
- Partials 742 752 +10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
arkodg
reviewed
Feb 2, 2024
arkodg
reviewed
Feb 2, 2024
arkodg
reviewed
Feb 2, 2024
| namespace = "" | ||
| } | ||
|
|
||
| switch strings.ToLower(resourceType) { |
There was a problem hiding this comment.
something for the future, dont want to block this PR, but all can be helpful here to fetch statuses of all CRDs at once
There was a problem hiding this comment.
sure, i will add this in a follow-up PR
|
this PR looks good @shawnh ! added a minor comment |
Signed-off-by: shawnh2 <[email protected]>
|
/retest |
cnvergence
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature: add
egctl x statussubcommandWhat this PR does / why we need it:
some examples:
Which issue(s) this PR fixes:
Fixes #2463