Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: move healthCheck to healthCheck.active #2540

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jan 31, 2024

Fixes: #2511

@arkodg arkodg requested a review from a team as a code owner January 31, 2024 03:20
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (241e838) 64.64% compared to head (38add42) 64.65%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/gatewayapi/backendtrafficpolicy.go 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
+ Coverage   64.64%   64.65%   +0.01%     
==========================================
  Files         116      116              
  Lines       17797    17809      +12     
==========================================
+ Hits        11504    11515      +11     
- Misses       5556     5558       +2     
+ Partials      737      736       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain merged commit fb8d48c into envoyproxy:main Jan 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider splitting up health check into active and passive to accommodate outlier detection
3 participants