api: support upstream max requests per connection #2513
Conversation
api/v1alpha1/circuitbreaker_types.go
Outdated
| @@ -7,14 +7,24 @@ package v1alpha1 | |||
|
|
|||
| // CircuitBreaker defines the Circuit Breaker configuration. | |||
| type CircuitBreaker struct { | |||
| // Settings related to both TCP and HTTP upstream connections | |||
There was a problem hiding this comment.
| // Settings related to both TCP and HTTP upstream connections | |
| // Settings related to TCP upstream connections |
There was a problem hiding this comment.
TCP settings like MaxConnections will apply to both TCP (e.g. TLS Passthrough) and HTTP connections. The HTTP struct contains settings that are relevant strictly to HTTP connections.
There was a problem hiding this comment.
in that case, the top level tcp and http doesnt seem very useful here and can be flattened into one, wdyt ?
There was a problem hiding this comment.
no problem. I'll update the API PR accordingly.
Signed-off-by: Guy Daich <[email protected]>
guydc
force-pushed
the
api-max-requests-per-connection
branch
from
f35369a to
60a53f6
Compare
guydc
changed the title
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2513 +/- ##
=======================================
Coverage 64.64% 64.64%
=======================================
Files 116 116
Lines 17797 17797
=======================================
Hits 11505 11505
Misses 5556 5556
Partials 736 736 ☔ View full report in Codecov by Sentry. |
| @@ -30,4 +30,11 @@ type CircuitBreaker struct { | |||
| // +kubebuilder:default=1024 | |||
| // +optional | |||
| MaxParallelRequests *int64 `json:"maxParallelRequests,omitempty"` | |||
|
|
|||
| // The maximum number of requests that Envoy will make over a single connection to the referenced backend defined within a xRoute rule. | |||
| // | |||
There was a problem hiding this comment.
can you highlight the default in the doc string ?
Signed-off-by: Guy Daich <[email protected]>
guydc
force-pushed
the
api-max-requests-per-connection
branch
from
cddd4e6 to
383d73b
Compare
Signed-off-by: Guy Daich <[email protected]>
|
/retest |
What this PR does / why we need it:
Adding
MaxRequestsPerConnectiontoCircuitBreaker, based on discussion in #2508. The implementation will translate the new attribute to the appropriate cluster's common http protocol options.Which issue(s) this PR fixes:
Fixes #2508