Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix printable for ir xds #2512

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jan 26, 2024

No description provided.

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg requested a review from a team as a code owner January 26, 2024 23:25
@zirain
Copy link
Member

zirain commented Jan 26, 2024

can you share more details about this? I think related to security?

@arkodg
Copy link
Contributor Author

arkodg commented Jan 27, 2024

can you share more details about this? I think related to security?

yes was added in #607, but recently broke

Signed-off-by: Arko Dasgupta <[email protected]>
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (2feae69) 64.70% compared to head (d008806) 64.71%.

❗ Current head d008806 differs from pull request most recent head ec95fc7. Consider uploading reports for the commit ec95fc7 to get more accurate results

Files Patch % Lines
internal/ir/xds.go 44.44% 5 Missing ⚠️
internal/ir/infra.go 0.00% 3 Missing ⚠️
internal/gatewayapi/runner/runner.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2512      +/-   ##
==========================================
+ Coverage   64.70%   64.71%   +0.01%     
==========================================
  Files         116      116              
  Lines       17576    17581       +5     
==========================================
+ Hits        11373    11378       +5     
- Misses       5476     5477       +1     
+ Partials      727      726       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg requested a review from a team January 27, 2024 00:31
@zhaohuabing zhaohuabing merged commit 93361a6 into envoyproxy:main Jan 27, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants