feat: support LabelSelector type for NamespaceSelectors

[deszhou]

What type of PR is this?

What this PR does / why we need it:

In the current configuration, the namespaceSelectors field under EnvoyGateway.Provider.Kubernetes.Wach only supports label selection using the key, similar to the Exists operator in LabelSelectorOperator.

The namespaceSelectors field can support a more comprehensive label-based selection, allowing you to specify both matchLabels and matchExpressions

namespaceSelectors:
  matchLabels:
    component: redis
  matchExpressions:
    - { key: tier, operator: In, values: [cache] }
    - { key: environment, operator: NotIn, values: [dev] }

https://pkg.go.dev/k8s.io/apimachinery/pkg/apis/meta/v1#LabelSelector

Which issue(s) this PR fixes:

Fixes #2481

[arkodg]

should this field be renamed to namespaceSelector ?

[deszhou]

yes, done

[zirain]

EG use squash merge model, please kindly don't force push everytime for better review.

[deszhou]

EG use squash merge model, please kindly don't force push everytime for better review.

I will pay attention to this. Can you help me look at the coverage-test? thank

[zirain]

--- FAIL: TestNamespaceSelectorProvider (67.82s)
    kubernetes_test.go:1372: 
        	Error Trace:	/home/runner/work/gateway/gateway/internal/provider/kubernetes/kubernetes_test.go:1372
        	Error:      	Condition never satisfied
        	Test:       	TestNamespaceSelectorProvider
2024-01-25T11:14:20.404Z	INFO	kubernetes/predicates.go:39	gatewayclass has matching controller name, processing	{"name": "test-gc"}
2024-01-25T11:14:20.404Z	INFO	kubernetes/predicates.go:43	bypassing reconciliation due to controller name	{"controller": "not.configured/controller"}
2024-01-25T11:14:20.406Z	DPANIC	kubernetes/predicates.go:123	non-string key argument passed to logging, ignoring all later arguments	{"invalid key": "not.configured/controller"}
2024-01-25T11:14:20.406Z	INFO	kubernetes/predicates.go:123	gatewayclass controller name
2024-01-25T11:14:20.406Z	INFO	kubernetes/predicates.go:124	gatewayclass name for gateway doesn't match configured name	{"namespace": "", "name": "scheduled-status-test"}
2024-01-25T11:14:20.407Z	DPANIC	kubernetes/predicates.go:123	non-string key argument passed to logging, ignoring all later arguments	{"invalid key": "not.configured/controller"}
2024-01-25T11:14:20.407Z	INFO	kubernetes/predicates.go:123	gatewayclass controller name
2024-01-25T11:14:20.407Z	INFO	kubernetes/predicates.go:124	gatewayclass name for gateway doesn't match configured name	{"namespace": "", "name": "scheduled-status-test"}
2024-01-25T11:14:20.417Z	INFO	kubernetes/routes.go:266	processing HTTPRoute	{"namespace": "test", "name": "test"}
2024-01-25T11:14:20.418Z	INFO	kubernetes/routes.go:266	processing HTTPRoute	{"namespace": "test", "name": "test"}
2024-01-25T11:14:20.418Z	INFO	kubernetes/routes.go:266	processing HTTPRoute	{"namespace": "test", "name": "test"}
2024-01-25T11:14:20.419Z	INFO	kubernetes/routes.go:137	processing GRPCRoute	{"namespace": "test", "name": "test"}

[shawnh2]

/retest

[shawnh2]

thanks for adding this, generally lgtm, just some nits.

[codecov]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c86681c) 64.68% compared to head (b48a8cd) 64.62%.
Report is 6 commits behind head on main.

Files	Patch %	Lines
internal/provider/kubernetes/predicates.go	50.00%	4 Missing and 2 partials ⚠️
internal/provider/kubernetes/controller.go	96.15%	1 Missing ⚠️
internal/provider/kubernetes/filters.go	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2494      +/-   ##
==========================================
- Coverage   64.68%   64.62%   -0.07%     
==========================================
  Files         115      115              
  Lines       17472    17513      +41     
==========================================
+ Hits        11302    11317      +15     
- Misses       5449     5471      +22     
- Partials      721      725       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[deszhou]

@shawnh2 done, thank!

[shawnh2]

LGTM, thanks

[arkodg]

LGTM thanks !