Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): remove kube-rbac-proxy leftovers #2450

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

shahar-h
Copy link
Contributor

What type of PR is this?
Remove kube-rbac-proxy leftovers from helm chart.

What this PR does / why we need it:
kube-rbac-proxy was removed here but its related RBAC resources were left in the chart. This PR removes them.

Which issue(s) this PR fixes: N/A

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner January 16, 2024 12:27
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ed8b20) 64.70% compared to head (337e9b7) 64.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2450      +/-   ##
==========================================
+ Coverage   64.70%   64.71%   +0.01%     
==========================================
  Files         115      115              
  Lines       17417    17417              
==========================================
+ Hits        11270    11272       +2     
+ Misses       5430     5429       -1     
+ Partials      717      716       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahar-h
Copy link
Contributor Author

/retest

@arkodg arkodg merged commit f4ed899 into envoyproxy:main Jan 17, 2024
17 checks passed
@shahar-h shahar-h deleted the remove-kube-rbac-proxy-leftovers branch January 17, 2024 07:57
zesiar0 pushed a commit to zesiar0/gateway that referenced this pull request Jan 22, 2024
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
Signed-off-by: A3bz <zeng921359373@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants