fix(helm): fix incorrect imagePullSecrets indentation #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shahar Harari <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2371 +/- ##
==========================================
- Coverage 64.66% 64.65% -0.01%
==========================================
Files 114 114
Lines 16616 16616
==========================================
- Hits 10744 10743 -1
+ Misses 5195 5194 -1
- Partials 677 679 +2 ☔ View full report in Codecov by Sentry. |
zirain
approved these changes
Dec 29, 2023
shawnh2
approved these changes
Dec 29, 2023
Xunzhuo
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix.
What this PR does / why we need it:
It fixes wrong indentation of imagePullSecrets in both EG deployment and certgen job - should be under pod spec instead of under container.
Tested by installing chart to kind cluster - once with default values and once with secret ref.
Which issue(s) this PR fixes: N/A