fix: fix backtrafficpolic is applied to routes with the same prefix #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaonan <[email protected]>
|
/retest |
zhaohuabing
reviewed
Dec 28, 2023
Signed-off-by: zhaonan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2368 +/- ##
==========================================
+ Coverage 64.62% 64.69% +0.07%
==========================================
Files 114 114
Lines 16616 16616
==========================================
+ Hits 10738 10750 +12
+ Misses 5199 5189 -10
+ Partials 679 677 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Using backendTrafficPolicies to patch route resources may lead to unexpected results.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2366