Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update watch ns api & add tests #2367

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

qicz
Copy link
Member

@qicz qicz commented Dec 27, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@qicz qicz requested a review from a team as a code owner December 27, 2023 09:39
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80ebd53) 64.75% compared to head (421f454) 64.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
- Coverage   64.75%   64.72%   -0.04%     
==========================================
  Files         113      113              
  Lines       16567    16567              
==========================================
- Hits        10728    10723       -5     
- Misses       5166     5170       +4     
- Partials      673      674       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: qicz <[email protected]>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

@zirain zirain merged commit 690e469 into envoyproxy:main Dec 27, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants