-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AllowCredentials knob to CORS setting #2307
Conversation
🚀 Thank you for contributing to the Envoy Gateway project! 🚀 Before merging, please ensure to follow the process below:
NOTE: Once your PR is under review, please do not rebase and force push it. Otherwise, it will force your reviewers to review the PR from scratch rather than simply look at your latest changes. What's more, you can help expedite the processing of your PR by
|
Signed-off-by: huabing zhao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
==========================================
+ Coverage 64.36% 64.39% +0.03%
==========================================
Files 112 112
Lines 15879 15882 +3
==========================================
+ Hits 10220 10227 +7
+ Misses 5010 5006 -4
Partials 649 649 ☔ View full report in Codecov by Sentry. |
🚀 Deployed on https://gateway-pr-2307-preview--eg-preview.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
Why we need this?
As an app developer, I want to send a cross-origin request to the server with credentials.
An example: #2296 (comment)
Related: #2296