Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward jwt tokens after verification #2300

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Dec 13, 2023

related: #2295

@zhaohuabing zhaohuabing requested a review from a team as a code owner December 13, 2023 10:04
Copy link

🚀 Thank you for contributing to the Envoy Gateway project! 🚀

Before merging, please ensure to follow the process below:

  1. Requesting Reviews:
  • cc @envoyproxy/gateway-reviewers team for an initial review.
  • After the initial review, reviewers should request the @envoyproxy/gateway-maintainers team for further review.
  1. Review Approval:
  • Your PR needs to receive at least two approvals.
  • At least one approval must come from a member of the gateway-maintainers team.

NOTE: Once your PR is under review, please do not rebase and force push it. Otherwise, it will force your reviewers to review the PR from scratch rather than simply look at your latest changes.

What's more, you can help expedite the processing of your PR by
  • Ensuring you have self-reviewed your work according to the project's Contribution Guidelines.
  • If your PR addresses a specific issue, make sure to mention it in the PR description.
  • Respond promptly if there are any test failures or suggestions for improvements that we comment on.

@zirain
Copy link
Member

zirain commented Dec 13, 2023

is there a test for this?

@zhaohuabing
Copy link
Member Author

is there a test for this?

I think we don't need to add a test for this, it should work as long as jwt test passed.

Signed-off-by: huabing zhao <[email protected]>
@zirain
Copy link
Member

zirain commented Dec 13, 2023

is there a test for this?

I think we don't need to add a test for this, it should work as long as jwt test passed.

we need make sure it's there, avoid regression in the future.

@zhaohuabing
Copy link
Member Author

zhaohuabing commented Dec 13, 2023

is there a test for this?

I think we don't need to add a test for this, it should work as long as jwt test passed.

we need make sure it's there, avoid regression in the future.

My bad. It's not bug. Sorry for the misleading "fix" word.

Signed-off-by: huabing zhao <[email protected]>
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f71f372) 64.38% compared to head (671d69c) 64.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
- Coverage   64.38%   64.27%   -0.11%     
==========================================
  Files         112      112              
  Lines       15874    15875       +1     
==========================================
- Hits        10220    10204      -16     
- Misses       5005     5018      +13     
- Partials      649      653       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xunzhuo Xunzhuo merged commit 176823c into envoyproxy:main Dec 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants