Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add user guide for EnvoyProxy HPA #2271

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ardikabs
Copy link
Contributor

@ardikabs ardikabs commented Dec 6, 2023

What type of PR is this?
Add user guide for EnvoyProxy HPA

What this PR does / why we need it:

Which issue(s) this PR fixes:

Related to #2257.
Close #2272

@ardikabs ardikabs requested a review from a team as a code owner December 6, 2023 08:41
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1c19dc) 64.36% compared to head (f03e0b9) 64.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2271      +/-   ##
==========================================
- Coverage   64.36%   64.35%   -0.02%     
==========================================
  Files         112      112              
  Lines       15874    15874              
==========================================
- Hits        10218    10215       -3     
- Misses       5007     5009       +2     
- Partials      649      650       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ardikabs ardikabs force-pushed the docs/add-user-guide-for-hpa branch from 5f79a2c to f911bde Compare December 6, 2023 09:23
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit. lgtm, thanks

site/content/en/latest/user/customize-envoyproxy.md Outdated Show resolved Hide resolved
@ardikabs ardikabs force-pushed the docs/add-user-guide-for-hpa branch from f911bde to f03e0b9 Compare December 6, 2023 17:19
@zirain zirain merged commit 00feeb4 into envoyproxy:main Dec 6, 2023
18 checks passed
@ardikabs ardikabs deleted the docs/add-user-guide-for-hpa branch December 7, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user guide for EnvoyProxy HPA
4 participants