user doc for oidc #2256
Merged
user doc for oidc #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
oidc-doc
branch
from
dfa7473 to
78737af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
- Coverage 64.29% 64.28% -0.02%
==========================================
Files 112 112
Lines 15728 15728
==========================================
- Hits 10112 10110 -2
- Misses 4976 4978 +2
Partials 640 640 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
oidc-doc
branch
from
cfcfcd7 to
78737af
Compare
zhaohuabing
force-pushed
the
oidc-doc
branch
2 times, most recently
from
449b109 to
8111b29
Compare
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
oidc-doc
branch
from
8111b29 to
c70dba4
Compare
shawnh2
reviewed
Nov 30, 2023
| ```shell | ||
| export ENVOY_SERVICE=$(kubectl get svc -n envoy-gateway-system --selector=gateway.envoyproxy.io/owning-gateway-namespace=default,gateway.envoyproxy.io/owning-gateway-name=eg -o jsonpath='{.items[0].metadata.name}') | ||
|
|
||
| sudo kubectl -n envoy-gateway-system port-forward service/${ENVOY_SERVICE} 443:443 |
There was a problem hiding this comment.
i don't think we need to bring sudo in
There was a problem hiding this comment.
It's because of the 443 port.
Co-authored-by: sh2 <[email protected]> Signed-off-by: Huabing Zhao <[email protected]>
Co-authored-by: sh2 <[email protected]> Signed-off-by: Huabing Zhao <[email protected]>
Co-authored-by: sh2 <[email protected]> Signed-off-by: Huabing Zhao <[email protected]>
|
/retest |
zirain
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2208