feat: OIDC Gateway API #2122
Merged
feat: OIDC Gateway API #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2122 +/- ##
==========================================
+ Coverage 64.22% 64.27% +0.05%
==========================================
Files 107 107
Lines 14665 14922 +257
==========================================
+ Hits 9418 9591 +173
- Misses 4677 4758 +81
- Partials 570 573 +3
|
zhaohuabing
changed the title
zhaohuabing
force-pushed
the
oidc-api
branch
4 times, most recently
from
47b72d1 to
ad198e2
Compare
zhaohuabing
changed the title
zhaohuabing
force-pushed
the
oidc-api
branch
4 times, most recently
from
d6974fa to
ef5a0a2
Compare
zhaohuabing
commented
Nov 7, 2023
zhaohuabing
commented
Nov 7, 2023
| "name", refGrant.Name) | ||
| } | ||
| } | ||
| resourceMap.allAssociatedNamespaces[secretNamespace] = struct{}{} // TODO Zhaohuabing do we need this line? |
There was a problem hiding this comment.
Do we need to check if this namespace exists?
zhaohuabing
force-pushed
the
oidc-api
branch
2 times, most recently
from
d7511f8 to
0164e76
Compare
arkodg
reviewed
Nov 10, 2023
arkodg
reviewed
Nov 10, 2023
|
hey @zhaohuabing this looks good, haven't looked at the implementation yet, added some minor comments reg API |
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
oidc-api
branch
from
0164e76 to
9bde314
Compare
Signed-off-by: huabing zhao <[email protected]>
arkodg
reviewed
Nov 10, 2023
arkodg
reviewed
Nov 10, 2023
arkodg
reviewed
Nov 10, 2023
arkodg
reviewed
Nov 10, 2023
arkodg
reviewed
Nov 10, 2023
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
|
/retest |
arkodg
reviewed
Nov 13, 2023
Signed-off-by: huabing zhao <[email protected]>
arkodg
reviewed
Nov 13, 2023
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
arkodg
requested review from
a team and
cnvergence
and removed request for
a team
zirain
approved these changes
Nov 13, 2023
|
User documentation would be even better. |
|
User docs will be in a follow-up PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
xds translation will be in a follow-up PR.
OIDC will be done per-route. The final xds output will look like this example yaml file: https://github.com/zhaohuabing/playground/blob/main/envoy/per-route-oauth2-oidc/envoy.yaml
Related: #881