Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team: add new reviewers of eg #2064

Merged
merged 2 commits into from
Oct 26, 2023
Merged

team: add new reviewers of eg #2064

merged 2 commits into from
Oct 26, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Oct 25, 2023

What type of PR is this?

team: add new reviewers of eg

What this PR does / why we need it:

Add new reviewers of eg.

Which issue(s) this PR fixes:

Fixes #2020

@Xunzhuo Xunzhuo requested a review from a team as a code owner October 25, 2023 08:40
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Oct 25, 2023

Hi forks, @alyssawilk @phlax ! Would you like to help invite new reviewers of eg to envoyproxy org and @envoyproxy/gateway-reviewers team?

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2064 (372ed02) into main (e4d9d7e) will increase coverage by 0.18%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
+ Coverage   65.04%   65.22%   +0.18%     
==========================================
  Files          99       99              
  Lines       14536    14640     +104     
==========================================
+ Hits         9455     9549      +94     
- Misses       4494     4505      +11     
+ Partials      587      586       -1     

see 8 files with indirect coverage changes

OWNERS Outdated
@@ -22,3 +22,7 @@ reviewers:
- LanceEa
- qicz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove qicz from here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@alyssawilk
Copy link

invites sent!

Signed-off-by: bitliu <[email protected]>
@Xunzhuo Xunzhuo requested a review from zirain October 26, 2023 02:29
@zirain zirain merged commit bec3f29 into envoyproxy:main Oct 26, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new reviewers to Envoy Gateway 🎉
4 participants