refactor: support custom gateway cert expiry days. #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qicz <[email protected]>
…t-cert-expiry-days
zirain
previously approved these changes
Oct 23, 2023
Signed-off-by: qicz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
- Coverage 65.38% 65.35% -0.04%
==========================================
Files 95 95
Lines 13939 13940 +1
==========================================
- Hits 9114 9110 -4
- Misses 4261 4264 +3
- Partials 564 566 +2
|
Signed-off-by: qicz <[email protected]>
…t-cert-expiry-days
|
/retest |
zirain
approved these changes
Oct 23, 2023
|
@qicz need at least two approval before merged |
ok |
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Nov 10, 2023
…y#2047)" This reverts commit 6b2c0e6. Signed-off-by: Arko Dasgupta <[email protected]>
zirain
added a commit
that referenced
this pull request
Nov 14, 2023
* Revert "refactor: support custom gateway cert expiry days. (#2047)" This reverts commit 6b2c0e6. Signed-off-by: Arko Dasgupta <[email protected]> * Default cert expire time to 5 years Signed-off-by: Arko Dasgupta <[email protected]> * fix overWriteControlPlaneCerts field Signed-off-by: Arko Dasgupta <[email protected]> * make generate Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: zirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2046