Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move validate envoy gateway #2024

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Oct 20, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1992

@Xunzhuo Xunzhuo requested a review from a team as a code owner October 20, 2023 03:46
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2024 (2be7255) into main (23c91a6) will increase coverage by 0.17%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #2024      +/-   ##
==========================================
+ Coverage   65.55%   65.73%   +0.17%     
==========================================
  Files          92       93       +1     
  Lines       13509    13515       +6     
==========================================
+ Hits         8856     8884      +28     
+ Misses       4107     4089      -18     
+ Partials      546      542       -4     
Files Coverage Δ
api/v1alpha1/validation/envoyproxy_validate.go 74.30% <ø> (ø)
internal/envoygateway/config/config.go 100.00% <100.00%> (+15.38%) ⬆️
api/v1alpha1/validation/envoygateway_validate.go 84.90% <84.90%> (ø)

... and 2 files with indirect coverage changes

@Xunzhuo Xunzhuo force-pushed the feat-move-validate branch from e4309ef to 2be7255 Compare October 20, 2023 06:30
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit ffd5418 into envoyproxy:main Oct 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decision: move EnvoyGateway config validation to api/v1alpha1/validation pkg
3 participants