Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: add favicons to eg website #1952

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Oct 11, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Now:
image

Before:
image

@Xunzhuo Xunzhuo requested a review from a team as a code owner October 11, 2023 03:19
@Xunzhuo Xunzhuo requested review from a team, kflynn, zhaohuabing and qicz and removed request for a team October 11, 2023 03:20
Copy link
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome,thanks

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1952 (fc28c5d) into main (3cdeabb) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1952      +/-   ##
==========================================
+ Coverage   65.39%   65.45%   +0.05%     
==========================================
  Files          90       90              
  Lines       13367    13367              
==========================================
+ Hits         8742     8750       +8     
+ Misses       4087     4080       -7     
+ Partials      538      537       -1     

see 2 files with indirect coverage changes

@arkodg arkodg merged commit 76704d1 into envoyproxy:main Oct 11, 2023
17 checks passed
@Xunzhuo Xunzhuo changed the title Design: add favicons to eg website design: add favicons to eg website Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants