Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:bump codespell and fix existing codespell errs #1933

Merged
merged 3 commits into from
Oct 7, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Oct 6, 2023

Taking #1924 forward

Signed-off-by: Arko Dasgupta <[email protected]>
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1933 (ebb2a68) into main (5d3c1b4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1933   +/-   ##
=======================================
  Coverage   65.46%   65.46%           
=======================================
  Files          90       90           
  Lines       13360    13360           
=======================================
  Hits         8746     8746           
+ Misses       4077     4076    -1     
- Partials      537      538    +1     
Files Coverage Δ
internal/gatewayapi/tls.go 100.00% <100.00%> (ø)
internal/ir/xds.go 75.51% <ø> (ø)

... and 2 files with indirect coverage changes

zirain
zirain previously approved these changes Oct 6, 2023
Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg requested review from zirain, a team, zhaohuabing, qicz and Xunzhuo and removed request for a team October 7, 2023 00:05
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@arkodg arkodg merged commit 1e73685 into envoyproxy:main Oct 7, 2023
20 checks passed
@arkodg arkodg deleted the bump-codespell-fix-errors branch October 7, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants