fix tls with jwt authn usecase #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
+ Coverage 65.87% 66.14% +0.26%
==========================================
Files 86 86
Lines 12924 12867 -57
==========================================
- Hits 8514 8511 -3
+ Misses 3866 3827 -39
+ Partials 544 529 -15
|
tanujd11
force-pushed
the
fix/tls-with-jwt-authn
branch
from
f9d8c61 to
61cfb8b
Compare
Xunzhuo
previously approved these changes
Sep 1, 2023
|
can you add test case for this? |
tanujd11
force-pushed
the
fix/tls-with-jwt-authn
branch
2 times, most recently
from
9f52017 to
c39ccc5
Compare
|
/retest |
1 similar comment
|
/retest |
tanujd11
force-pushed
the
fix/tls-with-jwt-authn
branch
from
27de98e to
df38ab4
Compare
|
/retest |
|
@zirain somehow |
|
seems related to #1859 |
|
/retest |
|
/retest |
zirain
reviewed
Sep 12, 2023
Signed-off-by: tanujd11 <[email protected]>
Signed-off-by: tanujd11 <[email protected]>
Signed-off-by: tanujd11 <[email protected]>
Signed-off-by: tanujd11 <[email protected]>
tanujd11
force-pushed
the
fix/tls-with-jwt-authn
branch
from
58a8c76 to
8a61129
Compare
zirain
approved these changes
Sep 13, 2023
arkodg
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What this PR does / why we need it:
HTTPS and JWT authentication was not working in tandem because for some reason we were getting the information for JWTRequirement from HCM in DefaultFilterChain. DefaultFilterChain is not populated in case of HTTPS.
The question is irRoute already have all the information about JWT Requirement as the HCM of listener is also populated from route only which only checks if the listener has JWT Filter on the route and patch listener. Then why reverse check is done if httpfilter has the JWT requirements?
Which issue(s) this PR fixes:
Fixes #1768