Added docs and fix for ref grant in service import case #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tanujd11 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
+ Coverage 65.29% 65.39% +0.09%
==========================================
Files 86 86
Lines 12526 12526
==========================================
+ Hits 8179 8191 +12
+ Misses 3828 3818 -10
+ Partials 519 517 -2
|
Xunzhuo
approved these changes
Sep 5, 2023
|
/retest |
|
/retest seems like a github issue |
|
/retest |
|
@zirain just a code patch |
Xunzhuo
requested review from
a team,
zhaohuabing,
LanceEa and
chauhanshubham
and removed request for
a team
qicz
approved these changes
Sep 5, 2023
Xunzhuo
added a commit
to Xunzhuo/gateway
that referenced
this pull request
Sep 6, 2023
Signed-off-by: bitliu <[email protected]>
zirain
pushed a commit
that referenced
this pull request
Sep 6, 2023
* 🐛 Fix: follow-up of #1852 Signed-off-by: bitliu <[email protected]> * 🎉 Update Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds docs for the Multicluster services service import.
A fix is added for service import working with reference grant.
Which issue(s) this PR fixes:
Fixes #