bump resource limits for Envoy Gateway deployment #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to envoyproxy#1613 Signed-off-by: Arko Dasgupta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1617 +/- ##
==========================================
- Coverage 61.79% 61.70% -0.10%
==========================================
Files 81 81
Lines 12031 12031
==========================================
- Hits 7435 7424 -11
- Misses 4138 4146 +8
- Partials 458 461 +3 |
|
/retest |
zirain
approved these changes
Jul 3, 2023
Closed
qicz
reviewed
Jul 4, 2023
| requests: | ||
| cpu: 10m | ||
| memory: 64Mi | ||
| cpu: 100m |
There was a problem hiding this comment.
the requests does not need to increase. EG can run on cpu 10m and mem 64Mi. for the limits IMO can't fix memory hign usage. #1613 (comment)
There was a problem hiding this comment.
this is a a rough estimate on what values would satisfy lower and upper bounds for common case
There was a problem hiding this comment.
I see, but requests changing is unnecessary from my production env situation.
There was a problem hiding this comment.
isn't 10m too low to start off with ?
Xunzhuo
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1613
Must be revisited again when #1365 is completed