feat: Add EnvoyProxySpec.EnvoyDaemonSet. #1457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1457 +/- ##
==========================================
- Coverage 61.43% 61.42% -0.02%
==========================================
Files 79 80 +1
Lines 11439 11597 +158
==========================================
+ Hits 7028 7123 +95
- Misses 3950 4005 +55
- Partials 461 469 +8
|
Making EnvoyDeployment and EnvoyDaemonSet mutually exclusive. Also adds KubernetesPodSpec.NodeSelector. This is useful when there is no separate load-balancer or floating IPs routing to the cluster. Instead, some nodes are designated as public gateways. This allows for a fully self-contained Kubernetes cluster. Signed-off-by: Tommie Gannert <[email protected]>
Signed-off-by: Tommie Gannert <[email protected]>
Signed-off-by: Tommie Gannert <[email protected]>
|
Talking to @arkodg, DaemonSet might be the wrong approach. Though I still think there is a place for having the |
|
Pulling the plug on this. Probably not needed. See #1035. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow using a DaemonSet instead of Deployment for EnvoyProxy.
Making EnvoyDeployment and EnvoyDaemonSet mutually exclusive.
Also adds KubernetesPodSpec.NodeSelector.
This is useful when there is no separate load-balancer or floating IPs routing to the cluster. Instead, some nodes are designated as public gateways. This allows for a fully self-contained Kubernetes cluster.
Which issue(s) this PR fixes:
Part of #1035