kubernetes: support custom cluster dns domain #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hejianpeng <[email protected]>
Signed-off-by: hejianpeng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1375 +/- ##
==========================================
+ Coverage 62.27% 62.47% +0.19%
==========================================
Files 78 78
Lines 10946 10949 +3
==========================================
+ Hits 6817 6840 +23
+ Misses 3676 3660 -16
+ Partials 453 449 -4
|
qicz
reviewed
Apr 28, 2023
| @@ -244,7 +253,7 @@ func TestTranslateXdsWithExtension(t *testing.T) { | |||
| ir := requireXdsIRFromInputTestData(t, "extension-xds-ir", tc.name+".yaml") | |||
| tr := &Translator{ | |||
| GlobalRateLimit: &GlobalRateLimitSettings{ | |||
| ServiceURL: ratelimit.GetServiceURL("envoy-gateway-system"), | |||
| ServiceURL: ratelimit.GetServiceURL("envoy-gateway-system", "cluster.local"), | |||
There was a problem hiding this comment.
maybe use DefaultDNSDomain is better
There was a problem hiding this comment.
it's ok in a test.
qicz
reviewed
Apr 28, 2023
qicz
reviewed
Apr 28, 2023
qicz
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
kubernetes: support custom cluster dns domain
Which issue(s) this PR fixes:
Fixes #1280