Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: followup kubernetes/infrastruture refactoring. #1337

Merged
merged 11 commits into from
Apr 25, 2023

Conversation

qicz
Copy link
Member

@qicz qicz commented Apr 20, 2023

Fixes #1330

cc @zirain @arkodg

@qicz qicz requested a review from a team as a code owner April 20, 2023 09:15
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #1337 (845d757) into main (29ef454) will decrease coverage by 0.12%.
The diff coverage is 83.05%.

@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   62.30%   62.19%   -0.12%     
==========================================
  Files          76       78       +2     
  Lines       10837    10895      +58     
==========================================
+ Hits         6752     6776      +24     
- Misses       3640     3665      +25     
- Partials      445      454       +9     
Impacted Files Coverage Δ
...al/infrastructure/kubernetes/ratelimit/resource.go 100.00% <ø> (ø)
...nal/infrastructure/kubernetes/resource/resource.go 100.00% <ø> (ø)
internal/infrastructure/kubernetes/infra.go 38.23% <22.22%> (-30.19%) ⬇️
internal/infrastructure/kubernetes/infra_client.go 75.00% <75.00%> (ø)
...ternal/infrastructure/kubernetes/infra_resource.go 83.69% <83.69%> (ø)
...frastructure/kubernetes/proxy/resource_provider.go 88.76% <95.83%> (ø)
...ternal/infrastructure/kubernetes/proxy/resource.go 100.00% <100.00%> (ø)
internal/infrastructure/kubernetes/proxy_infra.go 100.00% <100.00%> (ø)
.../infrastructure/kubernetes/ratelimit/deployment.go 100.00% <100.00%> (ø)
...tructure/kubernetes/ratelimit/resource_provider.go 97.26% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: qicz <[email protected]>
@qicz qicz added kind/enhancement New feature or request area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. area/provider kind/refactor labels Apr 20, 2023
@qicz qicz requested review from a team, zhaohuabing, LanceEa, Xunzhuo, zirain and arkodg and removed request for a team April 20, 2023 09:50
@qicz qicz force-pushed the refactor-infrastructure branch from 24bdd67 to 5fca0b3 Compare April 24, 2023 07:28
Signed-off-by: qicz <[email protected]>
@arkodg
Copy link
Contributor

arkodg commented Apr 24, 2023

@zirain can you take a first look ?

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qicz can you split this into two PRs, one for refactor of applier, and another for the reset part.

Signed-off-by: qicz <[email protected]>
@qicz qicz force-pushed the refactor-infrastructure branch from 2d1925e to fa59a65 Compare April 25, 2023 03:15
Signed-off-by: qicz <[email protected]>
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xunzhuo Xunzhuo merged commit 4adbc2a into envoyproxy:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. area/provider kind/enhancement New feature or request kind/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

followup: refactor package infrastructure/kubernetes
4 participants