-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: setup action for cherrypick #1312
Conversation
Signed-off-by: hejianpeng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1312 +/- ##
==========================================
+ Coverage 61.79% 61.83% +0.04%
==========================================
Files 76 76
Lines 10718 10718
==========================================
+ Hits 6623 6628 +5
+ Misses 3648 3645 -3
+ Partials 447 445 -2 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
It can only work for one release version? Like if we update this with v0.4.0, we can only cherry-pick commits to v0.4.0, but if I want to cherry-pick commits to v0.3.0, v0.2.0 ... It can not work, right? |
Actually, I think we can make it more generic. For now, RM (release manager) is different for each release. |
this approach sgtm, another one im seeing is https://github.com/sqren/backport/tree/main |
it looks like a CLI, not a Github action? |
yeah its a CLI + GH action https://github.com/sqren/backport-github-action |
@arkodg so you think https://github.com/sqren/backport-github-action is better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks, good to add some guidance in release steps as a follow up to this PR
@AliceProxy you're RM of v0.4, can you take a look at this? |
Can we document these points in release proccess ? |
Signed-off-by: hejianpeng <[email protected]>
Signed-off-by: hejianpeng <[email protected]>
Signed-off-by: hejianpeng <[email protected]>
faf454b
to
ff215f7
Compare
@Xunzhuo done |
I think we need an approval from @AliceProxy |
Sorry, I was occupied with Kubecon pretty much all last week and I didn't notice this today before I released v0.4.0. In general though I'm a +1 for this system for future releases. |
@AliceProxy can you give a approval to get this PR in? |
cherrypick/release-v0.4
laterNOTE: label(e.g.
cherrypick/release-v0.4
) should be added before merging PR.cc @AliceProxy @arkodg @Xunzhuo
BTW, need enable following options: