Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add helm values #1283

Merged
merged 2 commits into from
Apr 12, 2023
Merged

docs: add helm values #1283

merged 2 commits into from
Apr 12, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Apr 11, 2023

Fixes: #1276

@Xunzhuo Xunzhuo requested a review from a team as a code owner April 11, 2023 03:25
@Xunzhuo Xunzhuo marked this pull request as draft April 11, 2023 03:30
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #1283 (e487277) into main (cd18c96) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
+ Coverage   61.74%   61.77%   +0.03%     
==========================================
  Files          85       85              
  Lines       10761    10761              
==========================================
+ Hits         6644     6648       +4     
+ Misses       3676     3671       -5     
- Partials      441      442       +1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo closed this Apr 11, 2023
@Xunzhuo Xunzhuo reopened this Apr 11, 2023
```

To uninstall the chart:

``` shell
helm delete eg
```

## Values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !
is this written by hand ?
is there any tool that generates this :) ?

Copy link
Member Author

@Xunzhuo Xunzhuo Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, follow up issue to incorporate it into the project :)

@Xunzhuo Xunzhuo marked this pull request as ready for review April 12, 2023 06:13
@Xunzhuo Xunzhuo merged commit f96e838 into envoyproxy:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for Helm values.yaml
3 participants