Remove unused helm values #1277
Conversation
Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
force-pushed
the
unusued-helm-values
branch
from
f340649 to
a2a8f07
Compare
|
hey @Xunzhuo should we also disable |
Codecov Report
@@ Coverage Diff @@
## main #1277 +/- ##
==========================================
- Coverage 61.10% 61.06% -0.05%
==========================================
Files 85 85
Lines 10766 10766
==========================================
- Hits 6579 6574 -5
- Misses 3756 3760 +4
- Partials 431 432 +1 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -69,7 +69,7 @@ spec: | |||
| - --v=0 | |||
| env: | |||
| - name: KUBERNETES_CLUSTER_DOMAIN | |||
| value: {{ .Values.kubernetesClusterDomain }} | |||
There was a problem hiding this comment.
Imo we need to treat helm values as APi fields and expose them when needed, else we cause breaking changes, the goal of this PR is to expose minimum helm values needed for 0.4.0
There was a problem hiding this comment.
but this need be configurable in the future, xref: #1280
|
Thoughts on #1277 (comment) ? |
|
Merge it since I am adding docs for values |
No description provided.