refactor status conditions logic for Gateway API resources

[arkodg]

Description:
The GatewayClass and Gateway logic for computing status conditions lives here
https://github.com/envoyproxy/gateway/blob/main/internal/status/conditions.go

and the logic for Routes lives here

gateway/internal/gatewayapi/contexts.go

Line 89 in 085e6fa

func (l *ListenerContext) SetCondition(conditionType v1beta1.ListenerConditionType, status metav1.ConditionStatus, reason v1beta1.ListenerConditionReason, message string) {

These should be consolidated to one place for improving code reuse

[Pawan-Bishnoi]

Hi @arkodg
I would like to work on this.
Seems like we would be able to remove duplicate code by changing SetCondition to something like this:

func (l *ListenerContext) SetCondition(conditionType v1beta1.ListenerConditionType, status metav1.ConditionStatus, reason v1beta1.ListenerConditionReason, message string) {
	cond := statusPkg.NewCondition(...)

        l.gateway.Status.Listeners[l.listenerStatusIdx].Conditions = statusPkg.MergeConditions(l.gateway.Status.Listeners[l.listenerStatusIdx].Conditions, cond)
}

Does that sound ok? Any other ideas?

[Pawan-Bishnoi]

actually that would cause an import cycle. Let me think about this a bit more tomorrow.

[shawnh2]

assign myself of this one since i've been working with #2631

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days.