Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Status with PolicyAncestorStatus in CTP, BTP and SP #2631

Closed
arkodg opened this issue Feb 16, 2024 · 4 comments · Fixed by #2910
Closed

Replace Status with PolicyAncestorStatus in CTP, BTP and SP #2631

arkodg opened this issue Feb 16, 2024 · 4 comments · Fixed by #2910
Assignees
@shawnh2
Labels
area/api API-related issues area/policy
Milestone
Backlog

Comments

@arkodg
Copy link
Contributor

arkodg commented Feb 16, 2024

Description:

Describe the issue.

Use the upstream PolicyAncestorStatus definition which creates a top level structure per controller
https://gateway-api.sigs.k8s.io/geps/gep-713/#standard-status-struct

instead of what we have today e.g.

gateway/api/v1alpha1/backendtrafficpolicy_types.go

Line 97 in 1775624

type BackendTrafficPolicyStatus struct {

Should fix #2520
@arkodg arkodg added triage help wanted Extra attention is needed area/api API-related issues area/policy and removed triage labels Feb 16, 2024
@arkodg arkodg added this to the v1.0.0-rc1 milestone Feb 16, 2024
@shawnh2 shawnh2 mentioned this issue Feb 28, 2024
Closed
@shawnh2 shawnh2 self-assigned this Feb 28, 2024
@shawnh2 shawnh2 removed the help wanted Extra attention is needed label Feb 28, 2024
@shawnh2
Copy link
Contributor

shawnh2 commented Feb 28, 2024

by updating Status in Policies to PolicyAncestorStatus, this will also requires some changes in egctl x status

@shawnh2 shawnh2 mentioned this issue Feb 28, 2024
Merged
@shawnh2
Copy link
Contributor

shawnh2 commented Feb 28, 2024

should we change it directly to PolicyAncestorStatus or instead consider PolicyStatus which each Ancestors can refer to objects that are either the Target of a policy or above it in terms of object hierarchy, as described in here?

@arkodg
Copy link
Contributor Author

arkodg commented Feb 28, 2024 •
edited
Loading

ah I meant using the struct you referenced PolicyStatus https://github.com/kubernetes-sigs/gateway-api/blob/72f679c7c67228f5b4340e0c2f50cc04b36945b1/apis/v1alpha2/policy_types.go#L187, thanks for clarifying

@arkodg arkodg changed the title Replace PolicyStatus with PolicyAncestorStatus in CTP, BTP and SP Replace Status with PolicyAncestorStatus in CTP, BTP and SP Feb 28, 2024
@arkodg arkodg mentioned this issue Feb 28, 2024
Closed
@arkodg
Copy link
Contributor Author

arkodg commented Feb 28, 2024

blocked on #2724 (comment)

@arkodg arkodg removed the road-to-ga label Mar 2, 2024
@arkodg arkodg modified the milestones: v1.0.0-rc1, Backlog Mar 2, 2024
This was referenced Mar 6, 2024
Merged
Merged
@zhaohuabing zhaohuabing mentioned this issue Mar 9, 2024
Merged
This was referenced Mar 12, 2024
Closed
Merged
Closed
Merged
This was referenced Mar 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnh2 shawnh2

Labels
area/api API-related issues area/policy
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

feat: add PolicyStatus for EnvoyPatchPolicy shawnh2/gateway
2 participants
@arkodg @shawnh2