Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky TestE2E/RateLimitBasedJwtClaims test #2095

Closed
arkodg opened this issue Oct 27, 2023 · 1 comment · Fixed by #2097
Closed

Fix flaky TestE2E/RateLimitBasedJwtClaims test #2095

arkodg opened this issue Oct 27, 2023 · 1 comment · Fixed by #2097
Assignees
@zhaohuabing
Labels
area/ci CI and build related issues area/conformance Gateway API Conformance Related Issues help wanted Extra attention is needed kind/bug Something isn't working
Milestone
0.6.0

Comments

@arkodg
Copy link
Contributor

arkodg commented Oct 27, 2023

Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

Seen in https://github.com/envoyproxy/gateway/actions/runs/6669763416/job/18128552609

Most likely related to #2086

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Environment:

Include the environment like gateway version, envoy version and so on.

Logs:

Include the access logs and the Envoy logs.
@arkodg arkodg added kind/bug Something isn't working area/ci CI and build related issues labels Oct 27, 2023
@arkodg arkodg added this to the 0.6.0 milestone Oct 27, 2023
@arkodg
Copy link
Contributor Author

arkodg commented Oct 27, 2023

cc @zhaohuabing

@arkodg arkodg added the help wanted Extra attention is needed label Oct 27, 2023
arkodg added a commit to arkodg/gateway that referenced this issue Oct 27, 2023
@arkodg
Skip RateLimitBasedJwtClaimsTest test
d8dad8c 
Relates to envoyproxy#2095

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg mentioned this issue Oct 27, 2023
Merged
@arkodg arkodg added the area/conformance Gateway API Conformance Related Issues label Oct 27, 2023
arkodg added a commit that referenced this issue Oct 27, 2023
@arkodg
Skip RateLimitBasedJwtClaimsTest test (#2096)
ef7a2a4 
Relates to #2095

Signed-off-by: Arko Dasgupta <[email protected]>
@zhaohuabing zhaohuabing self-assigned this Oct 28, 2023
@zhaohuabing zhaohuabing mentioned this issue Oct 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaohuabing zhaohuabing

Labels
area/ci CI and build related issues area/conformance Gateway API Conformance Related Issues help wanted Extra attention is needed kind/bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Fix TestE2E/RateLimitBasedJwtClaims test zhaohuabing/gateway
2 participants
@zhaohuabing @arkodg